linux-kernel - Re: [PATCH] x86,vdso: Set VM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrXiv4JX6_V72D=3zpD0ozpnZWwEQnSQapQ_zNrWSbhz6A@mail.gmail.com>
Date:	Fri, 25 Jul 2014 16:27:52 -0700
From:	Andy Lutomirski <luto@...capital.net>
To:	"H. Peter Anvin" <hpa@...or.com>, X86 ML <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:	Andy Lutomirski <luto@...capital.net>
Subject: Re: [PATCH] x86,vdso: Set VM_MAYREAD for the vvar vma

On Fri, Jul 25, 2014 at 4:27 PM, Andy Lutomirski <luto@...capital.net> wrote:
> AFAIK this has no effect whatsoever unless x86 suddenly turns into a
> nommu architecture.  Nonetheless, not setting it is suspicious.

Sorry, forgot to mention: this is based on tip/x86/vdso.

--Andy

>
> Reported-by: Nathan Lynch <Nathan_Lynch@...tor.com>
> Signed-off-by: Andy Lutomirski <luto@...capital.net>
> ---
>  arch/x86/vdso/vma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/vdso/vma.c b/arch/x86/vdso/vma.c
> index dbef622..970463b 100644
> --- a/arch/x86/vdso/vma.c
> +++ b/arch/x86/vdso/vma.c
> @@ -138,7 +138,7 @@ static int map_vdso(const struct vdso_image *image, bool calculate_addr)
>         vma = _install_special_mapping(mm,
>                                        addr,
>                                        -image->sym_vvar_start,
> -                                      VM_READ,
> +                                      VM_READ|VM_MAYREAD,
>                                        &vvar_mapping);
>
>         if (IS_ERR(vma)) {
> --
> 1.9.3
>



-- 
Andy Lutomirski
AMA Capital Management, LLC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/