linux-kernel - Re: [PATCH] cpufreq: Fix latency for cpufreq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Jul 2014 11:06:16 +0530
From:	pramod gurav <pramod.gurav.etc@...il.com>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	Nicholas Krause <xerofoify@...il.com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cpufreq: Fix latency for cpufreq_info

Viresh,
Be careful when you ACK Nick's patches. He has confessed he has no
idea how to build test a kernel. His patches are NOT AT ALL build
tested. And some of his patches are being reverted for causing
problems in build and all. He looks for FIXME and removes/edits the
code as per the comments. Just be careful.

On Mon, Jul 14, 2014 at 12:00 PM, Viresh Kumar <viresh.kumar@...aro.org> wrote:
> On 14 July 2014 11:58, Nicholas Krause <xerofoify@...il.com> wrote:
>> This fixes the latency for the cpufreq policy to 1 million nanoseconds
>> that calls the function pxa_cpu_init for the member of the structure
>> called cpuinfo.transition_latency.
>>
>> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
>> ---
>>  drivers/cpufreq/pxa2xx-cpufreq.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/cpufreq/pxa2xx-cpufreq.c b/drivers/cpufreq/pxa2xx-cpufreq.c
>> index e24269a..e08bb98 100644
>> --- a/drivers/cpufreq/pxa2xx-cpufreq.c
>> +++ b/drivers/cpufreq/pxa2xx-cpufreq.c
>> @@ -372,7 +372,7 @@ static int pxa_cpufreq_init(struct cpufreq_policy *policy)
>>         init_sdram_rows();
>>
>>         /* set default policy and cpuinfo */
>> -       policy->cpuinfo.transition_latency = 1000; /* FIXME: 1 ms, assumed */
>> +       policy->cpuinfo.transition_latency = 1000000;
>>
>>         /* Generate pxa25x the run cpufreq_frequency_table struct */
>>         for (i = 0; i < NUM_PXA25x_RUN_FREQS; i++) {
>
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
Thanks and Regards
Pramod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/