linux-kernel - Re: [PATCH] nfs3_list_one_acl(): check get_acl() result with IS_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140727131917.GA32153@infradead.org>
Date:	Sun, 27 Jul 2014 06:19:17 -0700
From:	Christoph Hellwig <hch@...radead.org>
To:	Andrey Utkin <andrey.krieger.utkin@...il.com>
Cc:	trond.myklebust@...marydata.com, linux-kernel@...r.kernel.org,
	linux-nfs@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] nfs3_list_one_acl(): check get_acl() result with
 IS_ERR_OR_NULL

On Sat, Jul 26, 2014 at 02:58:01PM +0300, Andrey Utkin wrote:
> There was a check for result being not NULL. But get_acl() may return
> NULL, or ERR_PTR, or actual pointer.
> The purpose of the function where current change is done is to "list
> ACLs only when they are available", so any error condition of get_acl()
> mustn't be elevated, and returning 0 there is still valid.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=81111
> Signed-off-by: Andrey Utkin <andrey.krieger.utkin@...il.com>

Looks good, thanks!

Reviewed-by: Christoph Hellwig <hch@....de>

should probably get a cc to stable as the original patch has one
as well.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/