linux-kernel - Re: [PATCH v4] usb:serial:pl2303: add GPIOs interface on PL2303

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdaQwZQeshacMLnWSEL0X=rOQtDkoxcE-6+688EBp4ANLQ@mail.gmail.com>
Date:	Mon, 28 Jul 2014 12:16:14 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Wang YanQing <udknight@...il.com>,
	Greg KH <gregkh@...uxfoundation.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Johan Hovold <jhovold@...il.com>, andi@...as.de,
	dforsi@...il.com, One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] usb:serial:pl2303: add GPIOs interface on PL2303

On Thu, Jul 24, 2014 at 7:03 PM, Wang YanQing <udknight@...il.com> wrote:

> PL2303HX has two GPIOs, this patch add interface for it.
>
> Signed-off-by: Wang YanQing <udknight@...il.com>
> ---
>  Changes v3-v4:
>  1: fix missing static for gpio_dir_mask and gpio_value_mask
>  2: reduce unneeded compile macro defined suggested by gnomes@...rguk.ukuu.org.uk
>  3: use true instead of 1 corrected by Linus Walleij
>  4: ignore return value of gpiochip_remove suggested by Linus Walleij
>  5: fix multi gpio_chips registered by pl2303 can't be distinguished in kernel space.

This is OK with me now,
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/