lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 28 Jul 2014 12:24:21 +0200
From:	Michal Nazarewicz <mina86@...a86.com>
To:	Robert Baldyga <r.baldyga@...sung.com>, balbi@...com
Cc:	gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, m.szyprowski@...sung.com,
	andrzej.p@...sung.com
Subject: Re: [PATCH v2 2/3] usb: gadget: f_fs: add ioctl returning ep descriptor

>> On Fri, Jul 25 2014, Robert Baldyga wrote:
>>> This patch introduces ioctl named FUNCTIONFS_ENDPOINT_DESC, which
>>> returns endpoint descriptor to userspace. It works only if function
>>> is active.

> On 07/25/2014 04:15 PM, Michal Nazarewicz wrote:
>> I would argue that user space should never need to know the real
>> descriptor.  Is this ioctl needed for anything in particular?

On Mon, Jul 28 2014, Robert Baldyga <r.baldyga@...sung.com> wrote:
> It's needed, at least, to inform user space about maximum possible
> wMaxPacketSize value for the endpoint, which is returned by autoconfig
> through the endpoint descriptor when value set by user is zero.
>
> Descriptor returned form this ioctl is mostly the same as descriptor
> created by user. I guess you meant that real descriptor is this one,
> which contains real endpoint address, because it's probably only datum
> in real descriptor which should be never known by user space.
>
> This ioctl would be also useful in case, when FunctionFS daemon obtains
> endpoint descriptors from another daemon, and do not have access to
> original descriptor structures given do FunctionFS.

All right, I think I can go with that.

>>> Signed-off-by: Robert Baldyga <r.baldyga@...sung.com>

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +--<mpn@...gle.com>--<xmpp:mina86@...ber.org>--ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists