linux-kernel - Re: [PATCH 02/27] perf tools: Fix jump label always changing during tracing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140728104916.GA14215@gmail.com>
Date:	Mon, 28 Jul 2014 12:49:16 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	linux-kernel@...r.kernel.org,
	Adrian Hunter <adrian.hunter@...el.com>,
	David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Namhyung Kim <namhyung@...il.com>,
	Paul Mackerras <paulus@...ba.org>,
	Stephane Eranian <eranian@...gle.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCH 02/27] perf tools: Fix jump label always changing during
 tracing


* Jiri Olsa <jolsa@...hat.com> wrote:

> On Mon, Jul 28, 2014 at 08:58:44AM +0200, Peter Zijlstra wrote:
> > On Fri, Jul 25, 2014 at 12:36:44PM -0300, Arnaldo Carvalho de Melo wrote:
> > > From: Adrian Hunter <adrian.hunter@...el.com>
> > > 
> > > Intel PT decoding walks the object code to reconstruct the trace.  A
> > > jump label change during tracing causes decoding errors.
> > > 
> > > The "Enable close-on-exec flag on perf file descriptor" patch caused
> > > there to be always a jump label change.
> > > 
> > > It was found that using a per-cpu context instead of a per-thread
> > > context for the probe of the close-on-exec feature, made the problem go
> > > away.
> > 
> > per-cpu events are privileged, wouldn't this change make CLOEXEC always
> > undetected for normal users?
> > 
> > Also, the $subject doesn't related to CLOEXEC at all.
> 
> right, it would.. Ingo, still any chance to skip this one?
> 
> [jolsa@...p-26-214 perf]$ ./perf record sleep 1
> perf_event_open(..., PERF_FLAG_FD_CLOEXEC) failed with unexpected error 13 (Permission denied)
> perf_event_open(..., 0) failed unexpectedly with error 13 (Permission denied)
> 
> jirka

No, sorry - mind any of you please send a pull request with a fix or a 
revert?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/