linux-kernel - Re: linux-next: build failure after merge of the slave-dma tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140728115653.GF3952@lukather>
Date:	Mon, 28 Jul 2014 13:56:53 +0200
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Vinod Koul <vinod.koul@...el.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: linux-next: build failure after merge of the slave-dma tree

Hi,

On Mon, Jul 28, 2014 at 12:46:22PM +0530, Vinod Koul wrote:
> On Mon, Jul 28, 2014 at 12:18:56PM +1000, Stephen Rothwell wrote:
> > Hi Vinod,
> > 
> > After merging the slave-dma tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > drivers/dma/sun6i-dma.c: In function 'sun6i_dma_dump_chan_regs':
> > drivers/dma/sun6i-dma.c:203:2: error: implicit declaration of function '__virt_to_phys' [-Werror=implicit-function-declaration]
> >   phys_addr_t reg = __virt_to_phys((unsigned long)pchan->base);
> >   ^
> > 
> > Caused by commit 555859308723 ("dmaengine: sun6i: Add driver for the
> > Allwinner A31 DMA controller").  Presumably missing an include file.
> > 
> > I have used the slave-dma tree from next-20140725 for today.
> 
> Thanks, Feng's robot also gave such warning. SInce maxime didnt send any
> fixes it, I am applying below to fix this.
> We shouldnt have used __virt_to_phys here

Thanks for taking care of this.

> 
> --x8---
> From: Vinod Koul <vinod.koul@...el.com>
> Date: Mon, 28 Jul 2014 11:57:25 +0530
> Subject: [PATCH 1/2] dmaengine: sun6i: fix build failure on x86, xilinx targets
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> Since the driver defined COMPILE_TEST, it gets compiled for different arch's.
> The driver uses __virt_to_phys() insteadof virt_to_phys, so replace it
> 
> drivers/dma/sun6i-dma.c: In function ‘sun6i_dma_dump_chan_regs’:
> drivers/dma/sun6i-dma.c:203: error: implicit declaration of function '__virt_to_phys'
> 
> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Vinod Koul <vinod.koul@...el.com>

Acked-by: Maxime Ripard <maxime.ripard@...e-electrons.com>

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)