lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 28 Jul 2014 13:22:11 +0100
From:	Mark Brown <>
To:	Nicolin Chen <>
Subject: Re: [PATCH v2] ASoC: wm8962: Let CODEC driver enable and disable its
 own MCLK

On Mon, Jul 28, 2014 at 07:41:58PM +0800, Nicolin Chen wrote:

> +	pdata->mclk = devm_clk_get(&i2c->dev, NULL);
> +

This is broken for deferred probe.

> +	clk_prepare_enable(wm8962->pdata.mclk);
> +

Missing error checking.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)

Powered by blists - more mailing lists