linux-kernel - Re: [PATCH v2 0/5] sched: Add on_rq states and remove several double rq locks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140728131944.GA2800@redhat.com>
Date:	Mon, 28 Jul 2014 15:19:44 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Kirill Tkhai <tkhai@...dex.ru>
Cc:	linux-kernel@...r.kernel.org, nicolas.pitre@...aro.org,
	peterz@...radead.org, pjt@...gle.com, rostedt@...dmis.org,
	umgwanakikbuti@...il.com, ktkhai@...allels.com,
	tim.c.chen@...ux.intel.com, mingo@...nel.org
Subject: Re: [PATCH v2 0/5] sched: Add on_rq states and remove several
	double rq locks

On 07/28, Kirill Tkhai wrote:
>
> You're right. We have to check for "task_migrating" in switched_from_fair().
> One more place is switched_from_dl().

Or we can simply check task_migrating() in __sched_setscheduler(), like
set_cpus_allowed() does.

This probably means that you should add this check into task_rq_lock() as
Peter suggests. Or at least add another task_rq_lock_xxx() helper.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/