linux-kernel - Re: [PATCH] kernel: debug: kdb: kdb_io.c: Cleaning up missing null-terminate in conjunction with strncpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jK9Fm9Yw4mNoSZ7+B3LyvTbWx5fyOcB46V8=J4kLa2d3Q@mail.gmail.com>
Date:	Mon, 28 Jul 2014 10:18:06 -0400
From:	Kees Cook <keescook@...omium.org>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Jason Wessel <jason.wessel@...driver.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Borislav Petkov <bp@...e.de>,
	Randy Dunlap <rdunlap@...radead.org>,
	kgdb-bugreport@...ts.sourceforge.net,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kernel: debug: kdb: kdb_io.c: Cleaning up missing
 null-terminate in conjunction with strncpy

On Sat, Jul 26, 2014 at 10:44 AM, Rickard Strandqvist
<rickard_strandqvist@...ctrumdigital.se> wrote:
> Replacing strncpy with strlcpy to avoid strings that lacks null terminate.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>  kernel/debug/kdb/kdb_io.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c
> index 7c70812..27977c0 100644
> --- a/kernel/debug/kdb/kdb_io.c
> +++ b/kernel/debug/kdb/kdb_io.c
> @@ -361,9 +361,9 @@ poll_again:
>                         kdb_printf("%s", buffer);
>                 } else if (tab != 2 && count > 0) {
>                         len_tmp = strlen(p_tmp);
> -                       strncpy(p_tmp+len_tmp, cp, lastchar-cp+1);
> +                       strlcpy(p_tmp+len_tmp, cp, lastchar-cp+1);
>                         len_tmp = strlen(p_tmp);
> -                       strncpy(cp, p_tmp+len, len_tmp-len + 1);
> +                       strlcpy(cp, p_tmp+len, len_tmp-len + 1);
>                         len = len_tmp - len;
>                         kdb_printf("%s", cp);
>                         cp += len;

It's not clear to me what this code is actually doing, but I think the
"+1" parts to these strncpy()s are there to include the NULL
character.

> @@ -442,7 +442,7 @@ poll_again:
>  char *kdb_getstr(char *buffer, size_t bufsize, char *prompt)
>  {
>         if (prompt && kdb_prompt_str != prompt)
> -               strncpy(kdb_prompt_str, prompt, CMD_BUFLEN);
> +               strlcpy(kdb_prompt_str, prompt, CMD_BUFLEN);

This seems like a good idea.

>         kdb_printf(kdb_prompt_str);
>         kdb_nextline = 1;       /* Prompt and input resets line number */
>         return kdb_read(buffer, bufsize);
> --
> 1.7.10.4
>

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/