| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Jul 2014 20:56:32 +0530 From: Himangi Saraogi <himangi774@...il.com> To: Mark Fasheh <mfasheh@...e.com>, Joel Becker <jlbec@...lplan.org>, ocfs2-devel@....oracle.com, linux-kernel@...r.kernel.org Cc: julia.lawall@...6.fr Subject: [PATCH] ocfs2: delete double assignment Delete successive assignments to the same location. The two assignments are simply identical. A simplified version of Coccinelle semantic match that finds this problem is as follows: // <smpl> @@ expression i; @@ *i = ...; i = ...; // </smpl> Signed-off-by: Himangi Saraogi <himangi774@...il.com> --- Should the fist assignment be initializing the pv_minor field? fs/ocfs2/stack_user.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/ocfs2/stack_user.c b/fs/ocfs2/stack_user.c index 13a8537..4bcbb9b 100644 --- a/fs/ocfs2/stack_user.c +++ b/fs/ocfs2/stack_user.c @@ -591,7 +591,6 @@ static int ocfs2_control_release(struct inode *inode, struct file *file) */ ocfs2_control_this_node = -1; running_proto.pv_major = 0; - running_proto.pv_major = 0; } out: -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists