lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Jul 2014 16:29:58 +0100 From: David Howells <dhowells@...hat.com> To: Himangi Saraogi <himangi774@...il.com> Cc: dhowells@...hat.com, linux-afs@...ts.infradead.org, linux-kernel@...r.kernel.org, julia.lawall@...6.fr Subject: Re: [PATCH] afs: delete double assignment Himangi Saraogi <himangi774@...il.com> wrote: > - afs_uuid.time_hi_and_version = (uuidtime >> 48) & AFS_UUID_TIMEHI_MASK; > afs_uuid.time_hi_and_version = AFS_UUID_VERSION_TIME; > > get_random_bytes(&clockseq, 2); > afs_uuid.clock_seq_low = clockseq; > - afs_uuid.clock_seq_hi_and_reserved = > - (clockseq >> 8) & AFS_UUID_CLOCKHI_MASK; > afs_uuid.clock_seq_hi_and_reserved = AFS_UUID_VARIANT_STD; This might be the wrong thing to do. I wonder if the lines following the ones deleted should be "|=" rather than "=". I'll have a look into it. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists