lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 28 Jul 2014 13:27:24 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Hans de Goede <hdegoede@...hat.com>
Cc:	Antoine Ténart 
	<antoine.tenart@...e-electrons.com>,
	sebastian.hesselbarth@...il.com, kishon@...com,
	alexandre.belloni@...e-electrons.com,
	thomas.petazzoni@...e-electrons.com, zmxu@...vell.com,
	jszhang@...vell.com, linux-arm-kernel@...ts.infradead.org,
	linux-ide@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v11 4/8] ata: libahci: allow to use multiple PHYs

On Mon, Jul 28, 2014 at 12:29:56PM +0200, Hans de Goede wrote:
...
> > +		if (!enabled_ports) {
> > +			dev_warn(dev, "No port enabled\n");
> > +			return ERR_PTR(-ENODEV);
> 
> This should be:
> 			rc = -ENODEV;
> 			goto err_out;
> 
> Sorry for not catching that sooner.
> 
> Other then that the entire series looks good and is:
> 
> Acked-by: Hans de Goede <hdegoede@...hat.com>

Antoine, can you please post an updated version of this patch?  No
need to repost the whole series.  Also, how should the series be
routed?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists