lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Mon, 28 Jul 2014 13:43:36 -0700
From:	"H. Peter Anvin" <>
To:	Eduardo Habkost <>
	Jeremy Fitzhardinge <>,
	Chris Wright <>,
	Alok Kataria <>,
	Rusty Russell <>,
	Thomas Gleixner <>,
	Ingo Molnar <>,,
Subject: Re: [PATCH] x86, paravirt: BUG_ON on {rd,wr}msr exceptions

As much as I hate adding new pvops, it might be the better answer, especially since those are the real native ops.

On July 28, 2014 1:39:55 PM PDT, Eduardo Habkost <> wrote:
>On Mon, Jul 28, 2014 at 12:18:10PM -0700, H. Peter Anvin wrote:
>> On 07/28/2014 12:04 PM, Eduardo Habkost wrote:
>> > When CONFIG_PARAVIRT is enabled, the kernel is ignoring exceptions
>> > the {rd,wr}msr instructions. This makes serious issues (either on
>> > guest kernel, or on the host) be silently ignored, and is different
>> > the native MSR code (which does not ignore the exceptions).
>> > 
>> > As paravirt.h already includes linux/bug.h, I don't see what was
>> > original issue preventing BUG_ON from being used.
>> > 
>> > Change rdmsr(), wrmsr(), and rdmsrl() to BUG_ON() on errors.
>> How much does this bloat the kernel?
>It seems to add 8 bytes to each {wr,rd}msr() call (4 extra
>test, jmp, ud2, jmp).
>allyesconfig, paravirt enabled, before:
>  text    data     bss     dec     hex filename
>108368312       23500872        55705600        187574784       b2e2a00
>allyesconfig, paravirt enabled, after:
>   text    data     bss     dec     hex filename
>108384438       23500904        55717888        187603230       b2e991e
>allyesconfig vmlinux is 28446 bytes larger.
>An alternative is to add read_msr_unsafe() & write_msr_unsafe() fields
>to pv_cpu_ops, pointing to native_read_msr() & native_write_msr().

Sent from my mobile phone.  Please pardon brevity and lack of formatting.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists