linux-kernel - Re: [PATCH -tip/master 3/7] locking/mcs: Remove obsolete comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1406581375.2411.52.camel@j-VirtualBox>
Date:	Mon, 28 Jul 2014 14:02:55 -0700
From:	Jason Low <jason.low2@...com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Davidlohr Bueso <davidlohr@...com>, mingo@...nel.org, aswin@...com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -tip/master 3/7] locking/mcs: Remove obsolete comment

On Mon, 2014-07-28 at 20:50 +0200, Peter Zijlstra wrote:
> On Mon, Jul 28, 2014 at 10:49:35AM -0700, Jason Low wrote:
> 
> > So if the function is inlined, perf report would show the contention
> > occurring in the calling function rather than the inlined function. As
> > an example, if we were to convert osq_lock() and mutex_spin_on_owner()
> > to inline, perf would report all the contention from both of those
> > functions occurring in just "__mutex_lock_slowpath()".
> 
> But that's easily fixed on the tool side, right? Dwarf info (as present
> in vmlinux when build with CONFIG_DEBUG_INFO) has all that.

Ok, one more reason to keep it as inline then  :)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/