lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Mon, 28 Jul 2014 07:54:39 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Sachin Kamat <sachin.kamat@...sung.com>
Cc:	linux-kernel@...r.kernel.org, spk.linux@...il.com
Subject: Re: [PATCH Resend 2/2] mfd: tps65912-spi: Remove unused variable

On Fri, 18 Jul 2014, Sachin Kamat wrote:

> ‘rx_buf’ is not used in this function.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@...sung.com>
> ---
>  drivers/mfd/tps65912-spi.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/tps65912-spi.c b/drivers/mfd/tps65912-spi.c
> index 69a5178bf152..de60ad98bd9f 100644
> --- a/drivers/mfd/tps65912-spi.c
> +++ b/drivers/mfd/tps65912-spi.c
> @@ -32,10 +32,9 @@ static int tps65912_spi_write(struct tps65912 *tps65912, u8 addr,
>  	unsigned long spi_data = 1 << 23 | addr << 15 | *data;
>  	struct spi_transfer xfer;
>  	struct spi_message msg;
> -	u32 tx_buf, rx_buf;
> +	u32 tx_buf;
>  
>  	tx_buf = spi_data;
> -	rx_buf = 0;
>  
>  	xfer.tx_buf	= &tx_buf;
>  	xfer.rx_buf	= NULL;

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists