linux-kernel - Re: [PATCH] drivers:mfd:omap-usb-host.c: Fix improper mask use.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Jul 2014 10:02:48 +0300
From:	Roger Quadros <rogerq@...com>
To:	Michael Welling <mwelling@...cinc.com>,
	<linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>,
	<gregkh@...uxfoundation.org>, <stern@...land.harvard.edu>,
	<balbi@...com>
Subject: Re: [PATCH] drivers:mfd:omap-usb-host.c: Fix improper mask use.

Hi Michael,

On 07/29/2014 02:01 AM, Michael Welling wrote:
> single-ulpi-bypass is a flag used for older OMAP3 silicon.
> 
> The flag when set, can excite code that improperly uses the
> OMAP_UHH_HOSTCONFIG_UPLI_BYPASS define to clear the corresponding bit.
> Instead it clears all of the other bits disabling all of the ports in
> the process.
> 
> Signed-off-by: Michael Welling <mwelling@...cinc.com>
> ---
>  drivers/mfd/omap-usb-host.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
> index b48d80c..33a9234 100644
> --- a/drivers/mfd/omap-usb-host.c
> +++ b/drivers/mfd/omap-usb-host.c
> @@ -445,7 +445,7 @@ static unsigned omap_usbhs_rev1_hostconfig(struct usbhs_hcd_omap *omap,
>  
>  		for (i = 0; i < omap->nports; i++) {
>  			if (is_ehci_phy_mode(pdata->port_mode[i])) {
> -				reg &= OMAP_UHH_HOSTCONFIG_ULPI_BYPASS;
> +				reg &= ~OMAP_UHH_HOSTCONFIG_ULPI_BYPASS;
>  				break;
>  			}
>  		}
> 

Acked-by: Roger Quadros <rogerq@...com>

Good catch!

It seems the regression was introduced by commit c4df00aed9e2 in v3.9.
Could you please cc this patch to stable@...r.kernel.org

cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/