linux-kernel - Re: [PATCH] HID: rmi: change logging level of log messages related to unexpected reports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1407291109380.16390@pobox.suse.cz>
Date:	Tue, 29 Jul 2014 11:10:02 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Benjamin Tissoires   
	<benjamin.tissoires@...hat.com>
cc:	Andrew Duggan <aduggan@...aptics.com>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: rmi: change logging level of log messages related
 to unexpected reports

On Tue, 15 Jul 2014, Benjamin Tissoires   wrote:

> On Jul 11 2014 or thereabouts, Andrew Duggan wrote:
> > Userspace tools may use hidraw to perform operations on the device from userspace while
> > hid-rmi is bound to the device. This can cause hid-rmi to print error messages when its
> > ->raw_event() callback gets called as the reports pass through the HID stack. In this case
> > receiving responses which were not initiated by hid-rmi is not actually an error so the resulting
> > error messages are incorrect and misleading. This patch changes the log messages to debug so
> > that the messages can be turned on in the event that there is a problem and there is not
> > a userspace tool running.
> > 
> > Signed-off-by: Andrew Duggan <aduggan@...aptics.com>
> > ---
> 
> Fair enough
> 
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>

[ sorry for late response, I am just re-appearing from vacation-land ]

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/