linux-kernel - Re: [RFC PATCH v1 13/70] x86, x2apic_cluster:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140729090015.GA29266@gchen.bj.intel.com>
Date:	Tue, 29 Jul 2014 05:00:16 -0400
From:	"Chen, Gong" <gong.chen@...ux.intel.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	linux-kernel@...r.kernel.org, mingo@...nel.org, tglx@...utronix.de,
	paulus@...ba.org, benh@...nel.crashing.org, tony.luck@...el.com,
	hpa@...or.com, jkosina@...e.cz, rafael.j.wysocki@...el.com,
	linux@....linux.org.uk, ralf@...ux-mips.org,
	schwidefsky@...ibm.com, davem@...emloft.net,
	viro@...iv.linux.org.uk, fweisbec@...il.com, cl@...ux.com,
	akpm@...ux-foundation.org, axboe@...nel.dk,
	JBottomley@...allels.com, neilb@...e.de,
	christoffer.dall@...aro.org, rostedt@...dmis.org, rric@...nel.org,
	gregkh@...uxfoundation.org, mhocko@...e.cz, david@...morbit.com
Subject: Re: [RFC PATCH v1 13/70] x86, x2apic_cluster: _FROZEN Cleanup

On Tue, Jul 29, 2014 at 10:44:33AM +0200, Borislav Petkov wrote:
> >  	switch (action) {
> >  	case CPU_UP_PREPARE:
> >  		if (!zalloc_cpumask_var(&per_cpu(cpus_in_cluster, this_cpu),
> > -					GFP_KERNEL)) {
> > +					GFP_KERNEL))
> >  			err = -ENOMEM;
> > -		} else if (!zalloc_cpumask_var(&per_cpu(ipi_mask, this_cpu),
> > -					       GFP_KERNEL)) {
> > +		else if (!zalloc_cpumask_var(&per_cpu(ipi_mask, this_cpu),
> > +					     GFP_KERNEL)) {
> >  			free_cpumask_var(per_cpu(cpus_in_cluster, this_cpu));
> >  			err = -ENOMEM;
> 
> You need to start restraining yourself and doing clean patches. Those
> changes here are unrelated, please drop them.
> 
> Go and reread Documentation/SubmittingPatches, section 3 in particular.
> 
Copy that.

> > +	if (test_and_clear_bit(CPU_TASKS_FROZEN, &action) &&
> 
> What.. why?
> 
Sorry for that.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)