linux-kernel - Re: [PATCH v2] memory hotplug: update the variables after memory removed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53D76DBD.9080403@huawei.com>
Date:	Tue, 29 Jul 2014 17:47:41 +0800
From:	Zhang Zhen <zhenzhang.zhang@...wei.com>
To:	David Rientjes <rientjes@...gle.com>
CC:	Dave Hansen <dave.hansen@...el.com>, <mgorman@...e.de>,
	Ingo Molnar <mingo@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	<wangnan0@...wei.com>, Linux MM <linux-mm@...ck.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] memory hotplug: update the variables after memory
 removed

On 2014/7/29 17:18, David Rientjes wrote:
> On Tue, 29 Jul 2014, Zhang Zhen wrote:
> 
>>>> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
>>>> index df1a992..fd7bd6b 100644
>>>> --- a/arch/x86/mm/init_64.c
>>>> +++ b/arch/x86/mm/init_64.c
>>>> @@ -673,15 +673,11 @@ void __init paging_init(void)
>>>>   * After memory hotplug the variables max_pfn, max_low_pfn and high_memory need
>>>>   * updating.
>>>>   */
>>>> -static void  update_end_of_memory_vars(u64 start, u64 size)
>>>> +static void  update_end_of_memory_vars(u64 end_pfn)
>>>
>>> Extra space that can be removed here at the same time as a cleanup.
>>>
>> Sorry, where is the extra space here?
>>
> 
> There are two spaces between the function identifier and the function 
> type whereas there is traditionally only one.  It existed before your 
> patch, it would just be nice to clean it up since you're already touching 
> the line.
> 
Ok. Thanks.
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/