linux-kernel - Re: [PATCH 3/4 v3] xen-pciback: use pci device flag operation helper function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 29 Jul 2014 20:34:02 +0800
From:	Ethan Zhao <ethan.kernel@...il.com>
To:	David Vrabel <david.vrabel@...rix.com>
Cc:	Ethan Zhao <ethan.zhao@...cle.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	linux-pci <linux-pci@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"<gleb@...nel.org>" <gleb@...nel.org>,
	"<pbonzini@...hat.com>" <pbonzini@...hat.com>,
	"<kvm@...r.kernel.org>" <kvm@...r.kernel.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	"<boris.ostrovsky@...cle.com>" <boris.ostrovsky@...cle.com>,
	"<xen-devel@...ts.xenproject.org>" <xen-devel@...ts.xenproject.org>,
	"<alex.williamson@...hat.com>" <alex.williamson@...hat.com>,
	"<alexander.h.duyck@...el.com>" <alexander.h.duyck@...el.com>
Subject: Re: [PATCH 3/4 v3] xen-pciback: use pci device flag operation helper function

On Tue, Jul 29, 2014 at 6:07 PM, David Vrabel <david.vrabel@...rix.com> wrote:
> On 29/07/14 05:06, Ethan Zhao wrote:
>> Use pci device flag operation helper functions when set device
>> to assigned or deassigned state.
>>
>> Signed-off-by: Ethan Zhao <ethan.zhao@...cle.com>
>
> Konrad already reviewed this but you've not included his reviewed-by tag.
>
> I don't understand why we bother with this flag on Xen since we never
> use it but:
>
> Acked-by: David Vrabel <david.vrabel@...rix.com>
>
> I'm expecting this to go via the PCI tree.

  Seems Bjorn still holds his bullet for last shot :)
>
> David
>
>> --- a/drivers/xen/xen-pciback/pci_stub.c
>> +++ b/drivers/xen/xen-pciback/pci_stub.c
>> @@ -133,7 +133,7 @@ static void pcistub_device_release(struct kref *kref)
>>       xen_pcibk_config_free_dyn_fields(dev);
>>       xen_pcibk_config_free_dev(dev);
>>
>> -     dev->dev_flags &= ~PCI_DEV_FLAGS_ASSIGNED;
>> +     pci_clear_dev_assigned(dev);
>>       pci_dev_put(dev);
>>
>>       kfree(psdev);
>> @@ -404,7 +404,7 @@ static int pcistub_init_device(struct pci_dev *dev)
>>       dev_dbg(&dev->dev, "reset device\n");
>>       xen_pcibk_reset_device(dev);
>>
>> -     dev->dev_flags |= PCI_DEV_FLAGS_ASSIGNED;
>> +     pci_set_dev_assigned(dev);
>>       return 0;
>>
>>  config_release:
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/