linux-kernel - Re: [PATCH v2 RESEND 17/23] pm8001: Fix invalid return when request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53D7A62D.2090709@redhat.com>
Date:	Tue, 29 Jul 2014 15:48:29 +0200
From:	Tomas Henzl <thenzl@...hat.com>
To:	Christoph Hellwig <hch@...radead.org>
CC:	Alexander Gordeev <agordeev@...hat.com>,
	linux-kernel@...r.kernel.org, xjtuwjp@...il.com,
	lindar_liu@...sh.com, linux-scsi@...r.kernel.org,
	linux-pci@...r.kernel.org,
	Suresh Thiagarajan <Suresh.Thiagarajan@...s.com>
Subject: Re: [PATCH v2 RESEND 17/23] pm8001: Fix invalid return when request_irq()
 failed

On 07/29/2014 03:20 PM, Christoph Hellwig wrote:
> On Tue, Jul 29, 2014 at 03:13:06PM +0200, Tomas Henzl wrote:
>> Hi, 
>> patch looks good.
>>
>> A correction in pm8001_request_irq might be added too to allow 
>> the INT-X path when pm8001_setup_msix fails, but that is not part 
>> of this fix.
>
> There's actually an equivalent fix already in through one of the
> previous pm8001 updates, so I skipped this one even if it already had an
> ACK.  The following pm8001 applied just fine, though.  Take a look, as
> I've already pushed out the updated drivers branch.

I'm a bit confused - you were not commenting my text above I think?

I see in drivers-for-3.17 this patch already applied 5607de7
but not yet the next one (18/23) which also has a review, is there another ack needed?

>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/