linux-kernel - Re: [PATCH] s390: net: ctcm_main.c: Cleaning up missing null-terminate in conjunction with strncpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20140729143532.GB4202@osiris>
Date:	Tue, 29 Jul 2014 16:35:32 +0200
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Ursula Braun <ubraun@...ux.vnet.ibm.com>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Frank Blaschka <blaschka@...ux.vnet.ibm.com>,
	linux-s390@...r.kernel.org, linux390@...ibm.com,
	Ursula Braun <ursula.braun@...ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] s390: net: ctcm_main.c: Cleaning up missing
 null-terminate in conjunction with strncpy

On Tue, Jul 29, 2014 at 03:19:47PM +0200, Rickard Strandqvist wrote:
> > It is guaranteed that the string ch->id always fits into CTCM_ID_SIZE.
> > What's in this case the benefit of replacing strncpy() by strlcpy()
> > here?
> 
> If it is really so! It can just as well replacing it with strcpy...

Or.. just leave the code alone.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/