lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 29 Jul 2014 16:59:10 +0200 From: Peter Zijlstra <peterz@...radead.org> To: Vincent Guittot <vincent.guittot@...aro.org> Cc: Rik van Riel <riel@...hat.com>, linux-kernel <linux-kernel@...r.kernel.org>, Michael Neuling <mikey@...ling.org>, Ingo Molnar <mingo@...nel.org>, jhladky@...hat.com, ktkhai@...allels.com, tim.c.chen@...ux.intel.com, Nicolas Pitre <nicolas.pitre@...aro.org> Subject: Re: [PATCH 1/2] sched: fix and clean up calculate_imbalance On Tue, Jul 29, 2014 at 11:04:50AM +0200, Vincent Guittot wrote: > > In situations where all the domains are overloaded, or where only the > > busiest domain is overloaded, that code is also superfluous, since > > the normal env->imbalance calculation will figure out how much to move. > > Remove the load_above_capacity calculation. > > IMHO, we should not remove that part which is used by prefer_sibling > > Originally, we had 2 type of busiest group: overloaded or imbalanced. > You add a new one which has only a avg_load higher than other so you > should handle this new case and keep the other ones unchanged Right, so we want that code for overloaded -> overloaded migrations such as not to cause idle cpus in an attempt to balance things. Idle cpus are worse than imbalance. But in case of overloaded/imb -> !overloaded migrations we can allow it, and in fact want to allow it in order to balance idle cpus. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists