linux-kernel - Re: [PATCH v2] spi/pxa2xx-pci: Add common clock framework support in PCI glue layer

Open Source and information security mailing list archives

Message-ID: <CAAQYJAtM79NJJtfNYda-yFk113nm-2D8gZE5x=gbnLt2_eUdzQ@mail.gmail.com>
Date:	Tue, 29 Jul 2014 18:13:06 +0200
From:	Andrea Adami <andrea.adami@...il.com>
To:	Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:	chiau.ee.chew@...el.com,
	Kweh Hock Leong <hock.leong.kweh@...el.com>,
	Russell King <linux@....linux.org.uk>,
	Darren Hart <dvhart@...ux.intel.com>, chiauee85@...il.com,
	linux-kernel@...r.kernel.org,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	linux-spi@...r.kernel.org, Mark Brown <broonie@...nel.org>,
	Eric Miao <eric.y.miao@...il.com>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2] spi/pxa2xx-pci: Add common clock framework support in
 PCI glue layer

On Fri, Jul 25, 2014 at 7:32 AM, Mika Westerberg
<mika.westerberg@...ux.intel.com> wrote:
> On Fri, Jul 25, 2014 at 01:10:54AM +0800, chiau.ee.chew@...el.com wrote:
>> From: Chew, Chiau Ee <chiau.ee.chew@...el.com>
>>
>> SPI PXA2XX core layer has dependency on common clock framework
>> to obtain information on host supported clock rate. Thus, we
>> setup the clock device in the PCI glue layer to enable PCI mode
>> host pass in the clock rate information.
>>
>> Signed-off-by: Chew, Chiau Ee <chiau.ee.chew@...el.com>
>> Acked-by: Kweh, Hock Leong <hock.leong.kweh@...el.com>
>
> Looks reasonable,
>
> Acked-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Hi,

note that a previous version of the patch breaks spi on pxa machines:
tested on pxa250 poodle and pxa255 corgi.
The patch is included in linux-Yocto since 3.14.

The evident error is the absence of the touchscreen and on corgi a total crash.
pxa2xx-spi: probe of pxa2xx-spi.1 failed with error -2

I sent the full logs to the pxa maintainers.
Please let me know if there are any trivial fixes to apply on the top
of this patch for the non-pci, non-DT boards or better workarounds.

Thanks

Andrea
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives