linux-kernel - Re: [PATCH 1/2] staging/nvec: Do not pass resource to mfd_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <21317349.CjmK2Kpl80@ax5200p>
Date:	Tue, 29 Jul 2014 22:23:17 +0200
From:	Marc Dietrich <Marc.Dietrich@...physik.uni-giessen.de>
To:	Thierry Reding <thierry.reding@...il.com>
Cc:	Julian Andres Klode <jak@...-linux.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	ac100@...ts.launchpad.net, linux-tegra@...r.kernel.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] staging/nvec: Do not pass resource to mfd_add_devices()

Am Dienstag 29 Juli 2014, 13:16:14 schrieb Thierry Reding:
> From: Thierry Reding <treding@...dia.com>
> 
> The mfd_add_devices() function takes a struct resource * as fifth
> argument, but the nvec driver passes in a void __iomem *. The driver
> gets away with it because none of the subdevices ever directly access
> the registers.
> 
> Since subdevices never need to access the registers we can simply pass
> NULL instead.
> 
> Signed-off-by: Thierry Reding <treding@...dia.com>

Acked-by: Marc Dietrich <marvin24@....de>

> ---
>  drivers/staging/nvec/nvec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 0a5c84ad3f41..815065837ce7 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -893,7 +893,7 @@ static int tegra_nvec_probe(struct platform_device
> *pdev) }
> 
>  	ret = mfd_add_devices(nvec->dev, -1, nvec_devices,
> -			      ARRAY_SIZE(nvec_devices), base, 0, NULL);
> +			      ARRAY_SIZE(nvec_devices), NULL, 0, NULL);
>  	if (ret)
>  		dev_err(nvec->dev, "error adding subdevices\n");

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/