linux-kernel - Re: [PATCHv3] Documentation: laptops: freefall.c: simplify to avoid null-termination problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 28 Jul 2014 17:17:54 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Pavel Machek <pavel@....cz>
CC:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Pali Rohár <pali.rohar@...il.com>,
	Stefan Weil <sw@...lnetz.de>, Jiri Kosina <jkosina@...e.cz>,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	trivial@...nel.org
Subject: Re: [PATCHv3] Documentation: laptops: freefall.c: simplify to avoid
 null-termination problems

On 07/28/14 04:13, Pavel Machek wrote:
> 
> Copying to local variable is actually not neccessary, if all we need
> to do is snprintf(). This also removes problem where devname could be
> missing zero termination.
> 
> Reported-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> Signed-off-by: Pavel Machek <pavel@....cz>

Applied.  Thanks.

> 
> diff --git a/Documentation/laptops/freefall.c b/Documentation/laptops/freefall.c
> index aab2ff0..5e44b20 100644
> --- a/Documentation/laptops/freefall.c
> +++ b/Documentation/laptops/freefall.c
> @@ -29,15 +29,12 @@ static const char app_name[] = "FREE FALL";
>  
>  static int set_unload_heads_path(char *device)
>  {
> -	char devname[64];
> -
>  	if (strlen(device) <= 5 || strncmp(device, "/dev/", 5) != 0)
>  		return -EINVAL;
> -	strncpy(devname, device + 5, sizeof(devname) - 1);
>  	strncpy(device_path, device, sizeof(device_path) - 1);
>  
>  	snprintf(unload_heads_path, sizeof(unload_heads_path) - 1,
> -				"/sys/block/%s/device/unload_heads", devname);
> +				"/sys/block/%s/device/unload_heads", device+5);
>  	return 0;
>  }
>  
> 
> 
> 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/