linux-kernel - Re: [PATCH] x86, efi: print debug values in Kib not MB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53D82623.4080903@redhat.com>
Date:	Tue, 29 Jul 2014 18:54:27 -0400
From:	Prarit Bhargava <prarit@...hat.com>
To:	Borislav Petkov <bp@...en8.de>
CC:	linux-kernel@...r.kernel.org, lszubowi@...hat.com,
	Matt Fleming <matt.fleming@...el.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	linux-efi@...r.kernel.org
Subject: Re: [PATCH] x86, efi: print debug values in Kib not MB



On 07/29/2014 06:36 PM, Borislav Petkov wrote:
> On Tue, Jul 29, 2014 at 06:32:56PM -0400, Prarit Bhargava wrote:
>> and it was best to keep the code simple with a KiB.
> 
> You're missing the point - the output doesn't get simple with KiB. Read
> the example I just gave you!
> 
> (13893632kiB) is actively *not* helping when one looks at it!

I did get your point and I'm (politely) disagreeing with it.  Your case ONLY
works if the number is _exactly_ 13GB.  What if it is 13.5?  Then we're still
rounding off and reporting 14GB.  Which, if this code is meant for debug, makes
no sense to me.  Why round it off?

P.

> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/