linux-kernel - Re: [PATCH] x86, efi: print debug values in Kib not MB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Jul 2014 16:44:25 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Joe Perches <joe@...ches.com>
cc:	Borislav Petkov <bp@...en8.de>,
	Prarit Bhargava <prarit@...hat.com>,
	linux-kernel@...r.kernel.org, lszubowi@...hat.com,
	Matt Fleming <matt.fleming@...el.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	linux-efi@...r.kernel.org
Subject: Re: [PATCH] x86, efi: print debug values in Kib not MB

On Tue, 29 Jul 2014, Joe Perches wrote:

> Maybe yet another vsprintf extension?
> 
> Maybe %pH<vartype> where vartype is one of [hh, h, u, ul, ull]
> with something like
> 	u64 t1 = (u64)*(appropriate cast)vartype;
> 	u64 t2 = t1;
> 	int index = 0;
> 	while ((t1 >>= 10)) {
> 		index++;
> 		t2 >>= 10;
> 	}
> 	
> to output the equivalent of
> 	%llu%s, t2, "bkmgtpezy"[index]
> ala dump_pagetables
> 

Prarit has a good point about unnecessarily rounding the value, which is 
exactly what the patch is addressing, and it wouldn't be good to be 
changing the units depending on the value if anybody is using it for 
anything other than reading it with their own two eyes.  Since 
EFI_PAGE_SIZE will always be in KB, it makes sense to export it in KB.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/