| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140730032334.GA15787@htj.dyndns.org> Date: Tue, 29 Jul 2014 23:23:34 -0400 From: Tejun Heo <tj@...nel.org> To: Lai Jiangshan <laijs@...fujitsu.com> Cc: linux-kernel@...r.kernel.org Subject: Re: [PATCH RFC 2/2 V2] workqueue: use dedicated creater kthread for all pools Hello, Lai. On Wed, Jul 30, 2014 at 08:32:51AM +0800, Lai Jiangshan wrote: > > Why? Just sleep and retry? What's the point of requeueing? > > Accepted your comments except this one which may need to discuss > for an additional round. Requeueing passes the retry to the > kthread_worker and gives a change to the other pools which are also > creating worker. But why is that a good idea? The fact that creation of a worker for a specific pool is completely coincidental. The failed pool itself isn't inherently blameable. It was just unlucky and moving onto a different pool doesn't improve the chance of success in any way. The only thing requeueing achieves is punishing the unlucky one by putting it at the back of the queue while adding complexity. > This patch will be deferred until 3.19 due to some unbound patches > are ready soon. We're too late for this merge window anyway. This is a pretty pervasive change after all. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists