lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20140730005623.EA57CC4062A@trevor.secretlab.ca> Date: Tue, 29 Jul 2014 18:56:23 -0600 From: Grant Likely <grant.likely@...aro.org> To: Stanimir Varbanov <svarbanov@...sol.com>, Stephen Boyd <sboyd@...eaurora.org> Cc: linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, Lee Jones <lee.jones@...aro.org>, Samuel Ortiz <sameo@...ux.intel.com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Pawel Moll <pawel.moll@....com>, Rob Herring <robh+dt@...nel.org>, Kumar Gala <galak@...eaurora.org>, Mark Rutland <mark.rutland@....com>, Courtney Cavin <courtney.cavin@...ymobile.com>, Bjorn Andersson <bjorn.andersson@...ymobile.com>, Josh Cartwright <joshc@...eaurora.org> Subject: Re: [PATCH v2 0/4] Support for Qualcomm QPNP PMIC's On Fri, 18 Jul 2014 19:13:52 +0300, Stanimir Varbanov <svarbanov@...sol.com> wrote: > On 07/18/2014 02:10 AM, Stephen Boyd wrote: > > On 07/17/14 09:17, Stanimir Varbanov wrote: > >> Hello everyone, > >> > >> Here is the continuation of patch sets sent recently about Qualcomm > >> QPNP SPMI PMICs. > >> > >> The previous version of the patch set can be found at [1]. > >> > >> Changes since v1: > >> - removed completely custom *of* parser > >> - renamed the mfd driver from qpnp-spmi to pm8xxx-spmi > >> - now MFD_PM8XXX_SPMI Kconfig option depends on SPMI > >> > >> Removing of the custom *of* parser leads to that that the *reg* devicetree > >> property cannot exist and therefore cannot be parsed to get PMIC peripheral > >> resources. I took this step aside because no one from mfd drivers does this > >> parsing. This will lead to inconvenience in the peripheral drivers to define > >> internally the SPMI base addresses depending on the compatible property > >> i.e. PMIC version. > > > > We should teach the of platform layer to translate reg properties up > > until the point that they can't be translated anymore. If they can't be > > translated all the way back to cpu addresses we can make the resource > > have IORESOURCE_REG instead of IORESOURCE_MEM and then said pmic > > platform drivers can use platform_get_resource() with IORESOURCE_REG > > instead of IORESOURCE_MEM to get the addresses. > > > > I considered this as an option, if it is acceptable by OF maintainers it > will be awesome. > > Rob, Grant, is that feasible? It doesn't really make sense to do that kind of translation because the resulting address only makes sense if you also know which node the translation stopped at. A better solution is a new api for retrieving bus-local addresses instead of a global physical address. That would requires passing in a node or device to use as the translation root. If the child isn't a descended of that node, or if translation isn't possible then it should straight out fail instead of providing a partially translated value. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists