linux-kernel - Re: [PATCH] mfd: ab8500-core: Use 'ifdef' for config options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140730072504.GD9030@lee--X1>
Date:	Wed, 30 Jul 2014 08:25:04 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Fabio Estevam <festevam@...il.com>
Cc:	linus.walleij@...aro.org, linux-kernel@...r.kernel.org,
	Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH] mfd: ab8500-core: Use 'ifdef' for config options

On Tue, 29 Jul 2014, Fabio Estevam wrote:

> From: Fabio Estevam <fabio.estevam@...escale.com>
> 
> The config symbol 'CONFIG_DEBUG_FS' should be protected by a 'ifdef' instead
> of a plain 'if'.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>
> ---
>  drivers/mfd/ab8500-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c
> index ce48aa7..bde2fc0 100644
> --- a/drivers/mfd/ab8500-core.c
> +++ b/drivers/mfd/ab8500-core.c
> @@ -1754,7 +1754,7 @@ static int ab8500_probe(struct platform_device *pdev)
>  	if (ret)
>  		return ret;
>  
> -#if CONFIG_DEBUG_FS
> +#ifdef CONFIG_DEBUG_FS
>  	/* Pass to debugfs */
>  	ab8500_debug_resources[0].start = ab8500->irq;
>  	ab8500_debug_resources[0].end = ab8500->irq;

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/