linux-kernel - Re: [PATCH] s390: net: qeth_core_main.c: Cleaning up missing null-terminate in conjunction with strncpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1406708378.22788.5.camel@BR9GV9YG.de.ibm.com>
Date:	Wed, 30 Jul 2014 10:19:38 +0200
From:	Ursula Braun <ubraun@...ux.vnet.ibm.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Frank Blaschka <blaschka@...ux.vnet.ibm.com>,
	linux-s390@...r.kernel.org, linux390@...ibm.com,
	Ursula Braun <ursula.braun@...ibm.com>,
	linux-kernel@...r.kernel.org,
	Heiko Carstens <heiko.carstens@...ibm.com>
Subject: Re: [PATCH] s390: net: qeth_core_main.c: Cleaning up missing
 null-terminate in conjunction with strncpy

On Tue, 2014-07-29 at 15:21 +0200, Rickard Strandqvist wrote:
> 
> Den 29 jul 2014 15:13 skrev "Ursula Braun"
> <ubraun@...ux.vnet.ibm.com>:
> >
> > On Sat, 2014-07-26 at 16:35 +0200, Rickard Strandqvist wrote:
> > > Replacing strncpy with strlcpy to avoid strings that lacks null
> terminate.
> > >
> > > Signed-off-by: Rickard Strandqvist
> <rickard_strandqvist@...ctrumdigital.se>
> > > ---
> > >  drivers/s390/net/qeth_core_main.c |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/s390/net/qeth_core_main.c
> b/drivers/s390/net/qeth_core_main.c
> > > index f54bec5..ec9b4d7 100644
> > > --- a/drivers/s390/net/qeth_core_main.c
> > > +++ b/drivers/s390/net/qeth_core_main.c
> > > @@ -5275,7 +5275,7 @@ static int qeth_add_dbf_entry(struct
> qeth_card *card, char *name)
> > >       new_entry = kzalloc(sizeof(struct qeth_dbf_entry),
> GFP_KERNEL);
> > >       if (!new_entry)
> > >               goto err_dbg;
> > > -     strncpy(new_entry->dbf_name, name, DBF_NAME_LEN);
> > > +     strlcpy(new_entry->dbf_name, name, DBF_NAME_LEN);
> > >       new_entry->dbf_info = card->debug;
> > >       mutex_lock(&qeth_dbf_list_mutex);
> > >       list_add(&new_entry->dbf_list, &qeth_dbf_list);
> >
> > It is guaranteed that the string ch->id always fits into
> DBF_NAME_LEN.
> > What's in this case the benefit of replacing strncpy() by strlcpy()
> > here?
> 
> Hi
> 
> If it is really so!
> It can just as well replacing it with strcpy...
> 
> BR
> Rickard Strandqvist

And what would be the benefit of this change? 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/