linux-kernel - Re: [PATCH] mtd: atmel_nand: increase chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53D8BC92.4050907@atmel.com>
Date:	Wed, 30 Jul 2014 17:36:18 +0800
From:	Josh Wu <josh.wu@...el.com>
To:	Raphael Poggi <poggi.raph@...il.com>, <dwmw2@...radead.org>,
	<computersforpeace@...il.com>, <linux-mtd@...ts.infradead.org>
CC:	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtd: atmel_nand: increase chip_delay

Hi, Raphael

On 7/29/2014 9:27 PM, Raphael Poggi wrote:
> Some nand with 8k page size like Micron MT29F32G08ABAAAWP need more than 20us.
>
> Signed-off-by: Raphaël Poggi <poggi.raph@...il.com>
> ---
>   drivers/mtd/nand/atmel_nand.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index e321c56..77bd877 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -2099,7 +2099,7 @@ static int atmel_nand_probe(struct platform_device *pdev)
>   	}
>   
>   	nand_chip->ecc.mode = host->board.ecc_mode;
> -	nand_chip->chip_delay = 20;		/* 20us command delay time */
> +	nand_chip->chip_delay = 40;		/* 40us command delay time */
>   
>   	if (host->board.bus_width_16)	/* 16-bit bus width */
>   		nand_chip->options |= NAND_BUSWIDTH_16;

I just post a patch [1] days ago which does almost the same thing to 
support 4k-page nand flash.
personally I am fine with your patch.

Brain, you only need to take care this patch. And drop my patch [1].

[1] http://patchwork.ozlabs.org/patch/372406/

Thanks.
Best Regards,
Josh Wu


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/