linux-kernel - Re: [PATCH] drivers: CCI: Correct use of ! and &

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 30 Jul 2014 11:32:45 +0100
From:	Punit Agrawal <punit.agrawal@....com>
To:	Olof Johansson <olof@...om.net>
Cc:	"arm\@kernel.org" <arm@...nel.org>, Arnd Bergmann <arnd@...db.de>,
	Himangi Saraogi <himangi774@...il.com>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
	"julia.lawall\@lip6.fr" <julia.lawall@...6.fr>,
	"linux-arm-kernel\@lists.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Will Deacon <will.deacon@....com>
Subject: Re: [PATCH] drivers: CCI: Correct use of ! and &

Olof Johansson <olof@...om.net> writes:

> On Tue, Jul 29, 2014 at 4:34 AM, Punit Agrawal <punit.agrawal@....com> wrote:
>> Hi Arnd,
>>
>> Will Deacon <will.deacon@....com> writes:
>>
>>> On Wed, Jul 23, 2014 at 04:01:56PM +0100, Punit Agrawal wrote:
>>>> > diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
>>>> > index 5a86da9..7af78df 100644
>>>> > --- a/drivers/bus/arm-cci.c
>>>> > +++ b/drivers/bus/arm-cci.c
>>>> > @@ -397,7 +397,8 @@ static irqreturn_t pmu_handle_irq(int irq_num, void *dev)
>>>> >            hw_counter = &event->hw;
>>>> >
>>>> >            /* Did this counter overflow? */
>>>> > -          if (!pmu_read_register(idx, CCI_PMU_OVRFLW) & CCI_PMU_OVRFLW_FLAG)
>>>> > +          if (!(pmu_read_register(idx, CCI_PMU_OVRFLW) &
>>>> > +                CCI_PMU_OVRFLW_FLAG))
>>>> >                    continue;
>>>>
>>>>
>>>> Going back to the manual, this fix looks correct.
>>>>
>>>> Acked-by: Punit Agrawal <punit.agrawal@....com>
>>>>
>>>> Will, would this go via your tree?
>>>
>>> Given that you're happy with it, I don't mind which tree it goes in.
>>> Probably deserves a CC stable on it too.
>>
>> The CCI PMU patches went via arm-soc. Are you happy to pick this fix with
>> the Ack and a Cc to stable.
>
> Yeah, we've been merging most of the CCI patches.
>
> Please resend the patch to arm@...nel.org if you want us to apply it.

Ok, thanks! I'll send the patch with the tags applied shortly.

>
>
> Thanks,
>
> -Olof
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/