linux-kernel - Re: [PATCH v2 02/29] nios2: Kernel booting and initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFiDJ596dR5XCPcAHJezFXR0dq4dMR0-dPFfmjEgpWv-9px=nw@mail.gmail.com>
Date:	Wed, 30 Jul 2014 18:58:16 +0800
From:	Ley Foon Tan <lftan@...era.com>
To:	Tobias Klauser <tklauser@...tanz.ch>
Cc:	Linux-Arch <linux-arch@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	Chung-Lin Tang <cltang@...esourcery.com>
Subject: Re: [PATCH v2 02/29] nios2: Kernel booting and initialization

On Wed, Jul 30, 2014 at 5:12 PM, Tobias Klauser <tklauser@...tanz.ch> wrote:
>> +/*
>> + * Stack layout in 'ret_from_exception':
>> + *
>> + * This allows access to the syscall arguments in registers r4-r8
>> + *
>> + *    0(sp) - r8
>> + *    4(sp) - r9
>> + *    8(sp) - r10
>> + *    C(sp) - r11
>> + *   10(sp) - r12
>> + *   14(sp) - r13
>> + *   18(sp) - r14
>> + *   1C(sp) - r15
>> + *   20(sp) - r1
>> + *   24(sp) - r2
>> + *   28(sp) - r3
>> + *   2C(sp) - r4
>> + *   30(sp) - r5
>> + *   34(sp) - r6
>> + *   38(sp) - r7
>> + *   3C(sp) - orig_r2
>> + *   40(sp) - ra
>> + *   44(sp) - fp
>> + *   48(sp) - sp
>> + *   4C(sp) - gp
>> + *   50(sp) - estatus
>> + *   54(sp) - status_extension (NOMMU only)
>> + *   58(sp) - ea
>> + */
>
> status_extension no longer exists and orig_r7 is missing in the list
> above. Since this corresponds to the order of struct pt_regs anyhow,
> this comment seems rather pointless to me, so you might as well want to
> remove it altogether.
Okay, I will remove these comments.
Thanks for review.

Regards
Ley Foon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/