linux-kernel - Re: [PATCH v5 00/11] Add DRM for stih4xx platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140730125523.GP4747@phenom.ffwll.local>
Date:	Wed, 30 Jul 2014 14:55:23 +0200
From:	Daniel Vetter <daniel@...ll.ch>
To:	Benjamin Gaignard <benjamin.gaignard@...aro.org>
Cc:	Dave Airlie <airlied@...il.com>,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linaro-mm-sig@...ts.linaro.org" <linaro-mm-sig@...ts.linaro.org>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>
Subject: Re: [PATCH v5 00/11] Add DRM for stih4xx platforms

On Wed, Jul 30, 2014 at 12:43:33PM +0200, Benjamin Gaignard wrote:
> I have push two additional patches on drm_kms_for_next-v7 branch to
> make the driver build as a module:
> - "gpu: drm: export drm_sysfs_connector_{add,remove} function"

Nope, you're using the wrong functions. Instead you should use
drm_connector_register/unregister. Please don't just export randome
functions without digging into the history a bit.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/