linux-kernel - Re: [PATCH-REPOST] thermal: of: look for sensor driver parent node if device node missing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140730132017.GC14219@developer>
Date:	Wed, 30 Jul 2014 09:20:17 -0400
From:	Eduardo Valentin <edubezval@...il.com>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	"rui.zhang@...el.com" <rui.zhang@...el.com>,
	"eduardo.valentin@...il.com" <eduardo.valentin@...il.com>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"javi.merino@....com" <javi.merino@....com>
Subject: Re: [PATCH-REPOST] thermal: of: look for sensor driver parent node
 if device node missing

Laxman,

On Tue, Jul 29, 2014 at 07:53:58PM +0530, Laxman Dewangan wrote:
> On Tuesday 29 July 2014 07:42 PM, Eduardo Valentin wrote:
> > Hello Laxman,
> >
> > On Fri, Jul 25, 2014 at 02:49:31PM +0530, Laxman Dewangan wrote:
> >> There are some mfd devices which supports junction thermal interrupt
> >> like ams,AS3722. The DT binding of these devices are defined as the
> >> flat and drivers for sub module of such devices are registered as
> >> the mfd_add_devices. In this method, the sub devices registered as
> >> platform driver and these do not have the of_node pointer on their
> >> device structure. In this case, use the parent of_node pointer to
> >> get the required of_node pointer.
> >>
> > Can you please elaborate a bit more on your proposal? So, you would
> > append the thermal zones on the DT node of the MFD device?
> 
> Yes, mfd node for ams,as3722 is flat node, almost all sub-module driver 
> have their property on this node only. Regulator have their own sub node 
> under this node.
> 
> as3722 {
>          compatible = "ams,as3722";
>          #gpio-contorller;
>          #gpio-cells = <2>;
>      ::::::::::
>          regulator {
>                  ::::
>          };
> };
> 
> 
> So in this, the thermal sensor driver's property is on the as3722 node 
> only and thermal zone need to refer this node for sensor.
> 
> However, as3722 thermal sensor driver is register as sub mfd devices 
> through mfd_add_devices() and thermal sensor drivers pdev->dev.of_node 
> does not have any valid pointer.

In such case, the MFD driver shall populate the required data while
creating the sub device, right?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/