[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140730133806.GK8181@intel.com>
Date: Wed, 30 Jul 2014 19:08:06 +0530
From: Vinod Koul <vinod.koul@...el.com>
To: Alexander Popov <a13xp0p0v88@...il.com>
Cc: Dan Williams <dan.j.williams@...el.com>, dmaengine@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] dmaengine: of: kconfig: select DMA_ENGINE when
DMA_OF is selected
On Wed, Jul 30, 2014 at 03:58:51PM +0400, Alexander Popov wrote:
> Select DMA_ENGINE when DMA_OF is selected since
> of_dma_xlate_by_chan_id() from drivers/dma/of-dma.c uses
> dma_get_slave_channel() from drivers/dma/dmaengine.c
>
Please give credit to reporter by adding "Reported-by:" tag in commit
It is also got practice to give error log
> Signed-off-by: Alexander Popov <a13xp0p0v88@...il.com>
Applied, now after adding reported tag and error log
--
~Vinod
> ---
> drivers/dma/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index 1eca7b9..f887b19 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -388,6 +388,7 @@ config DMA_ACPI
> config DMA_OF
> def_bool y
> depends on OF
> + select DMA_ENGINE
>
> comment "DMA Clients"
> depends on DMA_ENGINE
> --
> 1.8.4.2
>
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists