linux-kernel - Re: [PATCH] tty: serial: serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53D90340.3010000@suse.cz>
Date:	Wed, 30 Jul 2014 16:37:52 +0200
From:	Jiri Slaby <jslaby@...e.cz>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	gregkh@...uxfoundation.org
CC:	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: serial: serial_core.c: printk replacement

On 07/30/2014, 04:07 PM, Sudip Mukherjee wrote:
> printk replaced with corresponding dev_* 
> fixed two broken user-visible strings used by the corresponding printk
> 
> 
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@...il.com>
> ---
>  drivers/tty/serial/serial_core.c | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index 8bb19da..ef48d0f 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
...
> @@ -1974,8 +1974,8 @@ int uart_suspend_port(struct uart_driver *drv, struct uart_port *uport)
>  		for (tries = 3; !ops->tx_empty(uport) && tries; tries--)
>  			msleep(10);
>  		if (!tries)
> -			printk(KERN_ERR "%s%s%s%d: Unable to drain "
> -					"transmitter\n",
> +			dev_err(uport->dev,
> +				"%s%s%s%d: Unable to drain transmitter\n",
>  			       uport->dev ? dev_name(uport->dev) : "",

Hi, this does not look correct. You use uport->dev, but there is a test
whether it is NULL in the parameters.

You would have to investigate if and when uport->dev can be NULL and
document it in the commit log above.

thanks,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/