linux-kernel - Re: [PATCH] x86, efi: print debug values in Kib not MB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53D909C3.9050205@canonical.com>
Date:	Wed, 30 Jul 2014 16:05:39 +0100
From:	Colin Ian King <colin.king@...onical.com>
To:	Matt Fleming <matt@...sole-pimps.org>,
	Borislav Petkov <bp@...en8.de>
CC:	Prarit Bhargava <prarit@...hat.com>, linux-kernel@...r.kernel.org,
	lszubowi@...hat.com, Matt Fleming <matt.fleming@...el.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	linux-efi@...r.kernel.org
Subject: Re: [PATCH] x86, efi: print debug values in Kib not MB

On 30/07/14 15:48, Matt Fleming wrote:
> On Wed, 30 Jul, at 12:29:32AM, Borislav Petkov wrote:
>> On Tue, Jul 29, 2014 at 01:09:21PM -0400, Prarit Bhargava wrote:
>>> The current debug print in EFI does
>>>
>>> [    0.000000] efi: mem84: type=3, attr=0xf, range=[0x00000000645b5000-0x00000000645fb000) (0MB)
>>>
>>> and rounds off the size to 0MB and isn't very useful.  We should print this in
>>> Kib.  After applying this patch we get better info with
>>>
>>> [    0.000000] efi: mem84: type=3, attr=0xf, range=[0x00000000645b5000-0x00000000645fb000) (280kiB)
>>
>> Turning this into kiB unconditionally won't always work ok:
>>
>> First of all, there might be something which parses that output so I'd
>> make sure I'm not breaking that. Maybe fwts... Matt will know.
> 
> I'm not aware of anything that parses the dmesg output, but I'm
> including Colin in case he has any insight.
> 
That won't break fwts.

Colin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/