linux-kernel - Re: [PATCH 1/3] ARM: dts: Turn on USB host vbus on rk3288-evb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=Wm-cB3-xHQdOUAXyX2xeYrXxPN6wYZrAoC6WAQ9sQ_Bg@mail.gmail.com>
Date:	Wed, 30 Jul 2014 08:13:52 -0700
From:	Doug Anderson <dianders@...omium.org>
To:	Heiko Stübner <heiko@...ech.de>
Cc:	Kever Yang <kever.yang@...k-chips.com>,
	Sonny Rao <sonnyrao@...omium.org>,
	Arnd Bergmann <arnd@...db.de>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] ARM: dts: Turn on USB host vbus on rk3288-evb

Heiko,

On Wed, Jul 30, 2014 at 4:24 AM, Heiko Stübner <heiko@...ech.de> wrote:
> Am Dienstag, 29. Juli 2014, 16:24:31 schrieb Doug Anderson:
>> There is no phy driver that works on the Rockchip board for either USB
>> host port yet.  For now just hardcode the vbus signal to be on all the
>> time which makes both the dwc2 host and the EHCI port work.
>>
>> Signed-off-by: Doug Anderson <dianders@...omium.org>
>> ---
>>  arch/arm/boot/dts/rk3288-evb.dtsi | 18 ++++++++++++++++++
>>  1 file changed, 18 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi
>> b/arch/arm/boot/dts/rk3288-evb.dtsi index 749e20d..efd625e 100644
>> --- a/arch/arm/boot/dts/rk3288-evb.dtsi
>> +++ b/arch/arm/boot/dts/rk3288-evb.dtsi
>> @@ -35,6 +35,18 @@
>>                       debounce-interval = <100>;
>>               };
>>       };
>> +
>> +     /* This turns on vbus for both host0 (ehci) and host1 (dwc2) */
>> +     usb_host_vbus_regulator: usb-host-vbus-regulator {
>> +             compatible = "regulator-fixed";
>> +             enable-active-high;
>> +             gpio = <&gpio0 14 GPIO_ACTIVE_HIGH>;
>> +             pinctrl-names = "default";
>> +             pinctrl-0 = <&usb_host_vbus>;
>> +             regulator-name = "usb-host-vbus";
>> +             regulator-always-on;
>> +             regulator-boot-on;
>> +     };
>>  };
>
> It seems I have a slightly outdated schematics pdf for the evb ... and only
> see the OTG vbus pin, on <&gpio0 12>, but am missing the whole host vbus.

I have schematics that claim to be from January 25, 2014 and claim to
be rev 1.0.  On my schematics:

* GPIO0_B4 (12) = OTG_VBUS_DRV = pin 233 of the mainboard connector
* GPIO0_B6 (14) = HOST_VBUS_DRV = pin 239 of the mainboard connector

On the mainboard schematics I have the OTG signal (233) doesn't
actually go to the OTG port.  It goes to a debug header and nowhere
else.  The HOST VBUS controls VBUS on both of the two "host" ports.


> Could you think about finding another name for the handle? For example, in my
> incomplete evb-schematics the supply coming from the otg regulator is called
> vcc50_usb and there should be something similar for the host supply, so I'd
> like something like
>
>         vcc50_usbhost: usb-host-vbus-regulator { /* or whatever it gets called */
>         ...
>         };
>
> simply to keep with the supply names defined in the schematics - makes reading
> easier.

I did!  ;)  ...but I matched my schematics, not yours.  Can you
provide the date / version number from your schematics and we can see
which is newer?  Just for reference I was emailed schematics last week
but that doesn't necessarily guarantee that they're the newest ones.


Given the above, I'm not planning to spin this patch unless you
confirm you want me to.  Thanks!  :)

-Doug
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/