linux-kernel - Re: [PATCH] Staging: vt6655: staticfy variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140730191638.GA5493@pleinair.baobob.org>
Date:	Wed, 30 Jul 2014 21:16:40 +0200
From:	Guillaume Clement <gclement@...bob.org>
To:	Fernando Apesteguia <fernando.apesteguia@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, Tobias Klauser <tklauser@...tanz.ch>
Subject: Re: [PATCH] Staging: vt6655: staticfy variable

Hello,

> Add static to variable.
> Signed-off-by: Fernando Apesteguia <fernando.apesteguia@...il.com>
> ---
>  drivers/staging/vt6655/ioctl.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/ioctl.c
> b/drivers/staging/vt6655/ioctl.c
> index 65e5933..cc6e47b 100644
> --- a/drivers/staging/vt6655/ioctl.c
> +++ b/drivers/staging/vt6655/ioctl.c
> @@ -41,7 +41,7 @@
>  static int msglevel = MSG_LEVEL_INFO;
>
>  #ifdef WPA_SM_Transtatus
> -SWPAResult wpa_Result;
> +static SWPAResult wpa_Result;
>  #endif

This changes breaks the compilation (actually the linking). wpa_Result
is actually used in device_main.c in device_open with the following:

> #ifdef WPA_SM_Transtatus
> 	extern SWPAResult wpa_Result;
> #endif
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/