linux-kernel - Re: [PATCH v5 1/7] kernel: Add support for kernel restart handler call chain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53D95B2E.6040308@roeck-us.net>
Date:	Wed, 30 Jul 2014 13:53:02 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Stephen Boyd <sboyd@...eaurora.org>
CC:	linux-watchdog@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Ingo Molnar <mingo@...nel.org>,
	Russell King <linux@....linux.org.uk>,
	Heiko Stuebner <heiko@...ech.de>,
	Arnd Bergmann <arnd@...db.de>, linux-doc@...r.kernel.org,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	Catalin Marinas <catalin.marinas@....com>,
	Tomasz Figa <t.figa@...sung.com>,
	Randy Dunlap <rdunlap@...radead.org>,
	Will Deacon <will.deacon@....com>,
	linux-kernel@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>,
	Jonas Jensen <jonas.jensen@...il.com>,
	Wim Van Sebroeck <wim@...ana.be>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v5 1/7] kernel: Add support for kernel restart handler
 call chain

On 07/30/2014 01:18 PM, Stephen Boyd wrote:
> On 07/18/14 00:34, Guenter Roeck wrote:
>> +/**
>> + *	do_kernel_restart - Execute kernel restart handler call chain
>> + *
>> + *	Calls functions registered with register_restart_handler.
>> + *
>> + *	Expected to be called from machine_restart as last step of the restart
>> + *	sequence.
>> + *
>> + *	Restarts the system immediately if a restart handler function has been
>> + *	registered. Otherwise does nothing.
>> + */
>> +void do_kernel_restart(char *cmd)
>> +{
>> +	blocking_notifier_call_chain(&restart_handler_list, reboot_mode, cmd);
>> +}
>
> Has this been tested with scheduling while atomic checking
> (CONFIG_DEBUG_ATOMIC_SLEEP) or lockdep (CONFIG_PROVE_LOCKING)? ARM would
> call this with irqs disabled and blocking_notifier_call_chain() would
> spit out a warning when it tries to down_read() on it's semaphore. This
> should probably be an atomic notifier chain instead.
>

Good point. I'll update the code accordingly.

I'll wait for additional comments until early next week to avoid unnecessary
churn.

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/