linux-kernel - [PATCH] kexec-export-free_huge_page-to-vmcoreinfo-fix (was: Re: mmotm 2014-07-30-15-57 uploaded)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140731092452.GB13561@dhcp22.suse.cz>
Date:	Thu, 31 Jul 2014 11:24:52 +0200
From:	Michal Hocko <mhocko@...e.cz>
To:	akpm@...ux-foundation.org
Cc:	mm-commits@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, linux-fsdevel@...r.kernel.org,
	linux-next@...r.kernel.org, sfr@...b.auug.org.au,
	Atsushi Kumagai <kumagai-atsushi@....nes.nec.co.jp>,
	Baoquan He <bhe@...hat.com>, Vivek Goyal <vgoyal@...hat.com>
Subject: [PATCH] kexec-export-free_huge_page-to-vmcoreinfo-fix (was: Re:
 mmotm 2014-07-30-15-57 uploaded)

On Wed 30-07-14 15:58:50, Andrew Morton wrote:
> * kexec-export-free_huge_page-to-vmcoreinfo.patch

This one seems to be missing ifdef for CONFIG_HUGETLBFS
---
>From bcccb6696b89c700712421858b05dd89ea0d1ec5 Mon Sep 17 00:00:00 2001
From: Michal Hocko <mhocko@...e.cz>
Date: Thu, 31 Jul 2014 11:18:57 +0200
Subject: [PATCH] kexec-export-free_huge_page-to-vmcoreinfo-fix
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

free_huge_page is not defined for !CONFIG_HUGETLBFS. Fix the following
compilation error:

kernel/kexec.c: In function ‘crash_save_vmcoreinfo_init’:
kernel/kexec.c:1628:20: error: ‘free_huge_page’ undeclared (first use in this function)
  VMCOREINFO_SYMBOL(free_huge_page);

Signed-off-by: Michal Hocko <mhocko@...e.cz>
---
 kernel/kexec.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/kexec.c b/kernel/kexec.c
index a3ccf9d7174b..507614acf938 100644
--- a/kernel/kexec.c
+++ b/kernel/kexec.c
@@ -1625,7 +1625,9 @@ static int __init crash_save_vmcoreinfo_init(void)
 #endif
 	VMCOREINFO_NUMBER(PG_head_mask);
 	VMCOREINFO_NUMBER(PAGE_BUDDY_MAPCOUNT_VALUE);
+#ifdef CONFIG_HUGETLBFS
 	VMCOREINFO_SYMBOL(free_huge_page);
+#endif
 
 	arch_crash_save_vmcoreinfo();
 	update_vmcoreinfo_note();
-- 
2.0.1

-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/