linux-kernel - Re: [PATCH 3/4] arm64: LLVMLinux: Calculate current_thread_info from current_stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53DA6909.1050007@converseincode.com>
Date:	Thu, 31 Jul 2014 09:04:25 -0700
From:	Behan Webster <behanw@...verseincode.com>
To:	Andreas Färber <afaerber@...e.de>,
	ard.biesheuvel@...aro.org, catalin.marinas@....com,
	k.khlebnikov@...sung.com, olof@...om.net, peterz@...radead.org,
	takahiro.akashi@...aro.org, tglx@...utronix.de, will.deacon@....com
CC:	linux-kernel@...r.kernel.org, Mark Charlebois <charlebm@...il.com>,
	dwmw2@...radead.org, mingo@...nel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 3/4] arm64: LLVMLinux: Calculate current_thread_info from
 current_stack_pointer

On 07/30/14 22:31, Andreas Färber wrote:
> Hi,
>
> Am 31.07.2014 01:57, schrieb behanw@...verseincode.com:
>> From: Behan Webster <behanw@...verseincode.com>
>>
>> Use the global current_stack_pointer to get the value of the stack pointer.
>> This change supports being able to compile the kernel with both gcc and clang.
>>
>> Signed-off-by: Behan Webster <behanw@...verseincode.com>
>> Signed-off-by: Mark Charlebois <charlebm@...il.com>
>> Reviewed-by: Jan-Simon M??ller <dl9pf@....de>
> Something went wrong with ö encoding here and in 2/4.
Yeah. That keeps happening. :(

Thanks.

>> ---
>>   arch/arm64/include/asm/thread_info.h | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/include/asm/thread_info.h b/arch/arm64/include/asm/thread_info.h
>> index e6b6094..c2432d2 100644
>> --- a/arch/arm64/include/asm/thread_info.h
>> +++ b/arch/arm64/include/asm/thread_info.h
>> @@ -80,8 +80,8 @@ static inline struct thread_info *current_thread_info(void) __attribute_const__;
>>   
>>   static inline struct thread_info *current_thread_info(void)
>>   {
>> -	register unsigned long sp asm ("sp");
>> -	return (struct thread_info *)(sp & ~(THREAD_SIZE - 1));
>> +	return (struct thread_info *) \
> This is not a macro, so \ seems superfluous.
Doh. Indeed. Will fix.

Behan

-- 
Behan Webster
behanw@...verseincode.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/