linux-kernel - RE: [PATCH] staging: comedi: ii_pci20kc: request and ioremap memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DC148C5AA1CEBA4E87973D432B1C2D8825F2E536@P3PWEX4MB008.ex4.secureserver.net>
Date:	Thu, 31 Jul 2014 17:24:44 +0000
From:	Hartley Sweeten <HartleyS@...ionengravers.com>
To:	Ian Abbott <abbotti@....co.uk>,
	"driverdev-devel@...uxdriverproject.org" 
	<driverdev-devel@...uxdriverproject.org>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] staging: comedi: ii_pci20kc: request and ioremap memory

On Thursday, July 31, 2014 7:57 AM, Ian Abbott wrote:
> The "ii_pci20kc" module is a comedi driver for Intelligent Instruments
> PCI-20001C carrier board and modules.  Despite the name, this is
> actually an ISA board and uses 1K of ISA memory space (below 1M) for the
> main board plus up to three modules.  The address is set by hardware
> jumpers.
>
> When the board is attached to Comedi via the `COMEDI_DEVCONFIG` ioctl
> and the driver's legacy "attach" handler, the base address is passed in.
> The driver currently uses that address as-is, which is a bad idea.  It
> doesn't even reserve the memory region.
>
> Fix that by sanity checking the passed in address, reserving the memory
> region and ioremapping it.
>
> Replace the current "detach" handler `comedi_legacy_detach()` with a new
> handler `ii20k_detach()` which unmaps the memory and releases the
> region.
>
> Signed-off-by: Ian Abbott <abbotti@....co.uk>
> ---
>  drivers/staging/comedi/drivers/ii_pci20kc.c | 32 ++++++++++++++++++++++++++---
>  1 file changed, 29 insertions(+), 3 deletions(-)

Thanks for fixing this!

Reviewed-by: H Hartley Sweeten <hsweeten@...ionengravers.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/