linux-kernel - Re: [PATCH v4 3/4] ARM: dts: Clean up exynos5250-snow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53DA96C7.30009@gmail.com>
Date:	Thu, 31 Jul 2014 21:19:35 +0200
From:	Tomasz Figa <tomasz.figa@...il.com>
To:	Andreas Färber <afaerber@...e.de>,
	linux-samsung-soc@...r.kernel.org
CC:	Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org,
	Kukjin Kim <kgene.kim@...sung.com>,
	Vincent Palatin <vpalatin@...omium.org>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	open list <linux-kernel@...r.kernel.org>,
	Kumar Gala <galak@...eaurora.org>,
	Stephan van Schaik <stephan@...khronix.com>,
	Doug Anderson <dianders@...omium.org>,
	Rob Herring <robh+dt@...nel.org>,
	Ben Dooks <ben-linux@...ff.org>,
	Russell King <linux@....linux.org.uk>,
	Javier Martinez Canillas <javier.martinez@...labora.co.uk>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 3/4] ARM: dts: Clean up exynos5250-snow

Andreas,

Please see my comments inline.

On 31.07.2014 18:08, Andreas Färber wrote:
> Use the new style of referencing inherited nodes and use symbolic names.
> 
> Suggested-by: Doug Anderson <dianders@...omium.org>
> Signed-off-by: Andreas Färber <afaerber@...e.de>

[snip]

> -
>  	usb@...10000 {
> -		samsung,vbus-gpio = <&gpx1 1 0>;
> +		samsung,vbus-gpio = <&gpx1 1 GPIO_ACTIVE_HIGH>;
>  	};

This is a higher level node being overridden, so it should be specified
using references too.

>  
>  	fixed-rate-clocks {
> @@ -287,7 +206,7 @@
>  	};
>  
>  	hdmi {

Ditto.

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/