linux-kernel - Re: [PATCH v3] ASoC: wm8962: Let CODEC driver enable and disable its own MCLK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140731195323.GU17528@sirena.org.uk>
Date:	Thu, 31 Jul 2014 20:53:23 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Nicolin Chen <nicoleotsuka@...il.com>
Cc:	alsa-devel@...a-project.org, patches@...nsource.wolfsonmicro.com,
	linux-kernel@...r.kernel.org, b42378@...escale.com,
	b02247@...escale.com, festevam@...il.com
Subject: Re: [PATCH v3] ASoC: wm8962: Let CODEC driver enable and disable its
 own MCLK

On Tue, Jul 29, 2014 at 06:38:39PM +0800, Nicolin Chen wrote:
> snd_soc_open() will trigger pm_runtime resume() which will then enable
> the regulator and initialization. So we should make sure the MCLK is
> enabled before this resume().

Applied, thanks.  However the clock should really be being enabled in
the probe() as well so that runtime PM can then disable it - the current
probe() gets this wrong for the regulators though so this is fine for
now.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)