linux-kernel - RE: [PATCH 00/18] staging: comedi: amplc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DC148C5AA1CEBA4E87973D432B1C2D8825F33D7B@P3PWEX4MB002.ex4.secureserver.net>
Date:	Thu, 31 Jul 2014 20:28:04 +0000
From:	Hartley Sweeten <HartleyS@...ionengravers.com>
To:	Ian Abbott <abbotti@....co.uk>,
	"driverdev-devel@...uxdriverproject.org" 
	<driverdev-devel@...uxdriverproject.org>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 00/18] staging: comedi: amplc_pci224: remove legacy stuff

On Thursday, July 31, 2014 6:48 AM, Ian Abbott wrote:
> The "amplc_pci224" driver retains a "legacy" attach mechanism via the
> `COMEDI_DEVCONFIG` ioctl and the comedi driver "attach" hook, but
> usually attaches PCI devices automatically via the comedi driver's
> "auto_attach" hook.  The legacy mechanism is only retained so that
> options can be passed via the ioctl to indicate how some hardware
> jumpers are set on the boards, which is used to set up the range tables.
> That's no use if the PCI device is attached automatically as the range
> tables will be set up according to the factory default jumper positions.
>
> Change the range tables to include all possible ranges, regardless of
> jumper positions.  Then there is no need to have options to control
> setting up the range tables and the "legacy" attach mechanism can be
> removed.
>
> Also, tidy the code up a bit.

Looks good.

Reviewed-by: H Hartley Sweeten <hsweeten@...ionengravers.com>

Side note:

Now that the manual attach has been removed, you could also remove
the board information from the comedi_driver declaration.

Regards,
Hartley

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/